Skip to content

Resolves 6731 by adding a custom message for refunding shipping#18844

Merged
magento-engcom-team merged 7 commits intomagento:2.3-developfrom
Rus0:m2-6731
Oct 31, 2018
Merged

Resolves 6731 by adding a custom message for refunding shipping#18844
magento-engcom-team merged 7 commits intomagento:2.3-developfrom
Rus0:m2-6731

Conversation

@Rus0
Copy link
Copy Markdown
Contributor

@Rus0 Rus0 commented Oct 26, 2018

Description (*)

Fixed Issues (if relevant)

  1. 'Exception' with message 'Warning: Division by zero in vendor/magento/module-sales/Model/Order/Creditmemo/Total/Discount.php on line 32' in vendor/magento/framework/App/ErrorHandler.php:61 #6731: 'Exception' with message 'Warning: Division by zero in vendor/magento/module-sales/Model/Order/Creditmemo/Total/Discount.php on line 32' in vendor/magento/framework/App/ErrorHandler.php:61

Manual testing scenarios (*)

  1. Create a order with free shipment
  2. Invoice the order
  3. Create new creditmemo
  4. Refund $10 in Refund Shipping

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Copy Markdown
Contributor

magento-cicd2 commented Oct 26, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 26, 2018

Hi @Rus0. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

okorshenko
okorshenko suggested changes Oct 26, 2018
View reviewed changes
Comment thread app/code/Magento/Sales/Model/Order/Creditmemo/Total/Discount.php Outdated
Comment thread app/code/Magento/Sales/Model/Order/Creditmemo/Total/Discount.php Outdated
Comment thread app/code/Magento/Sales/Model/Order/Creditmemo/Total/Discount.php Outdated
Comment thread app/code/Magento/Sales/Model/Order/Creditmemo/Total/Discount.php
Oleksii Korshenko and others added 4 commits October 26, 2018 15:59
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 26, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 27, 2018

Hi @okorshenko, thank you for the review.
ENGCOM-3294 has been created to process this Pull Request

@okorshenko okorshenko mentioned this pull request Oct 31, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 73af54a into magento:2.3-develop Oct 31, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 31, 2018
@slavvka
ENGCOM-3294: Resolves 6731 by adding a custom message for refunding s…
59886f4 
…hipping #18844
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Oct 31, 2018

Hi @Rus0. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@gelanivishal gelanivishal mentioned this pull request Nov 2, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@okorshenko okorshenko okorshenko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@okorshenko okorshenko

Labels

Award: bug fix Component: Sales Event: mm18mx Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Rus0 @magento-cicd2 @magento-engcom-team @okorshenko